Fix for ww3_tp2.22 plus updates from dev/ufs-weather-model #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix2/sync-dev/unified * origin/mods/dev/ufs-weather-model: matrix_cmake_ncep: update modules for spack-stack prevent division by 0 in appendtail and add timers to meshcap (NOAA-EMC#1163)
|
Fyi @alperaltuntas @JessicaMeixner-NOAA No action needed now, I just wanted to give a heads up that this is coming down the pipe. I plan to submit the full PR for review the beginning of next week. This branch has successfully passed all UFS RT's, as well as some internal sanity check (standalone) testing. |
|
@alperaltuntas @JessicaMeixner-NOAA |
alperaltuntas
approved these changes
Mar 4, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Clean up regtest
ww3_tp2.22, along with currentdev/ufs-weather-modelbranchappendtailfix, anddevelopbranch Intel CI fix.Description
Provide a detailed description of what this PR does.
ww3_tp2.22. Additionally, thorough testing was done with results documented. Verifying the build in Github Actions required bringing in an Intel CI fix from NOAA-EMCdevelop. Syncing with NOAA-EMCdev/ufs-weather-modelincluded a potential divide-by-zero fix.What bug does it fix, or what feature does it add?
develop.dev/ufs-weather-model, which brings in potential divide-by-zero fix.ww3_tp2.22outputIs a change of answers expected from this PR?
mod_def's and associatedww3_grid*.out's will change due to Langmuir parameters being added to the grid definition.restart*.ww3) files in regtests that previously had differences, and now do not, likely due to the divide-by-zero fix.Please also include the following information:
mod_defs, though no other files should change).Issue(s) addressed
NA. Addresses latest comments in main PR.
Commit Message
Fix regtest ww3_tp2.22, potential divide-by-zero fix in appendtail, fix for Intel CI
Check list
Testing
ww3_tp2.22) and visual check of parameter values.ww3_tp2.22) was previously added to demonstrate the new functionality.hera/intel.mod_def.*and associatedww3_grid*.outchanges expected. The exact filenames for each regtest are documented below in the annotatedmatrixCompSummary.txtlisting below.I. Standalone WW3 regtests
I.a New non-b4b
The following from an annotated summary of changes (anot.2024-02-23.matrixCompSummary.txt) are the new non-b4b files, all of which are accounted as a:
mod_def*file or an associatedww3_grid*.outfile.I.b Known non-b4b's with new non-b4b's
The following tests contain both known non-b4b's, and unknown non-b4b's. Like above the unknown non-b4b's are all explained as either a
mod_defor associate grid log file. The raw list is first displayed below, followed by file listings for each of the known/unknown non-b4b's.II. Coupled UFS RTs
Note: new
mod_deffiles are needed to run allufs-weather-modelRTs with this branch.Final RT 'success' timestamp
III. Functionality check
To verify the added functionality, a new regression test,
ww3_tp2.22, had been previously added.A sample invocation
will produce additional output parameters (
uuss/vuss,uussh/vussh) which can be seen in the gridded netCDF output,ww3.196808.nc:Additionally, displaying gridded output fields allows a visual sanity check. The screenshot below shows sample
HS(left),UUSS(middle), andUUSSH.